Added 'small_angle' indicator to OSD flip arrow. #7250
Conversation
|
OSD unit test is failing but otherwise good. Tested on OMNIBUSF4SD and works as expected. I'm torn on which way the arrow should point when displayed in normal mode (not crash flip). At the moment it's following the crash flip logic indicating which way to push the stick. Not sure if this is more intuitive or the reverse would be better to indicate which way the quad is leaning. No opportunity to push the stick to level if you can't arm. My first impression was that it seemed backwards and then after thinking about it I understood what was going on. |
|
Yes, it is not intuitive at first glance, but the arrow pointing in the direction to pull the stick to once armed (in crash flip mode as it won't arm otherwise) seems a better option than showing the direction to pull in the theoretical case of arming without crash flip. |
This allows the 'crash flip arrow' to be used as an indicator for a tilted craft as well - the arrow will show when disarmed (only if
small_angleisn't set to 180) if the tilt angle is exceeded. When in crash flip mode, the arrow will only show when the tilt angle is exceeded.Also, cleaned up the calculation to use the proper quadrants, and cleaned up an unnecessary buffer variable in the small angle calculation.